LibSuiteSparse: Make init_suitesparse compatible with --trim - #754
Merged
Conversation
Splatting a `Vector` of unknown length into the `VersionNumber` constructor is not statically resolvable (juliac `--trim`); destructure the three components instead. This commit was written with the assistance of generative AI (Claude). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
`init_suitesparse` is a `OncePerProcess{Nothing}`, but its body ended in
`cond && atexit(...)`, whose value infers as `Bool`. Storing that into the
`Nothing` slot cannot be resolved statically (juliac `--trim`); return
`nothing` explicitly.
This commit was written with the assistance of generative AI (Claude).
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #754 +/- ##
=======================================
Coverage 83.85% 83.85%
=======================================
Files 13 13
Lines 9387 9389 +2
=======================================
+ Hits 7871 7873 +2
Misses 1516 1516 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
araujoms
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
...splat and implicit returnconverthere cannot be resolved by--trim(yet)